dominic/xn
dominic/xn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix integer operations (#6)

Browse Source 
Previously the arithmetic attempted bitwise binary ops for double types,
add explicit casts for these kind of binary ops.

Reviewed-on: #6
This commit is contained in:
Dominic Höglinger 2026-04-27 03:27:28 +00:00
parent efc5301728
commit 2d8c52ece0
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Parser/XnParser.cs
View File

@ -12,6 +12,7 @@ using Rule = XNeedle.Transformation.Rule;
using System.Data; using System.Data;
using System.ComponentModel.DataAnnotations; using System.ComponentModel.DataAnnotations;
using System.Text; using System.Text;
using System.Security.AccessControl;
namespace XNeedle.Parser namespace XNeedle.Parser
{ {
@ -126,7 +127,18 @@ namespace XNeedle.Parser
static Parser<Expression> Term(Context ctx) static Parser<Expression> Term(Context ctx)
{ {
return Parse.ChainOperator(Multiply.Or(Divide).Or(Modulo).Or(BitwiseXor).Or(BitwiseAnd).Or(BitwiseOr), InnerTerm(ctx), Expression.MakeBinary); return Parse.ChainOperator(Multiply.Or(Divide), InnerTerm(ctx), Expression.MakeBinary);
}
static Parser<Expression> IntegerTerm(Context ctx)
{
// Integer operations can't deal with doubles, so we need to make unary casts to integer and back
return Parse.ChainOperator(Multiply.Or(Divide).Or(Modulo).Or(BitwiseXor).Or(BitwiseAnd).Or(BitwiseOr),
InnerTerm(ctx), (bt,left,right)=>Expression.MakeUnary(
ExpressionType.Convert, Expression.MakeBinary(bt,
Expression.MakeUnary(ExpressionType.Convert, left, typeof(long)),
Expression.MakeUnary(ExpressionType.Convert, right, typeof(long))),
typeof(double)));
} }
static Parser<Expression> ConcatExpr(Context ctx) static Parser<Expression> ConcatExpr(Context ctx)
@ -141,7 +153,7 @@ namespace XNeedle.Parser
static Parser<Expression> ArithExpr(Context ctx) static Parser<Expression> ArithExpr(Context ctx)
{ {
return Parse.ChainOperator(Add.Or(Subtract), Term(ctx), Expression.MakeBinary); return Parse.ChainOperator(Add.Or(Subtract), IntegerTerm(ctx).Or(Term(ctx)), Expression.MakeBinary);
} }
static Parser<Expression> Expr(Context ctx) static Parser<Expression> Expr(Context ctx)