mirror of
https://github.com/ByteWelder/Tactility.git
synced 2026-02-18 19:03:16 +00:00
686f7cce83
FreeRTOS handles were stored plainly and they were deleted in the destructor of classes. This meant that if a class were to be copied, the destructor would be called twice on the same handles and lead to double-free. Seha on Discord suggested to fix this by using `std::unique_ptr` with a custom deletion function. The changes affect: - Thread - Semaphore - Mutex - StreamBuffer - Timer - MessageQueue - EventFlag Thread changes: - Removal of the hack with the `Data` struct - Thread's main body is now just a private static function inside the class. - The C functions were relocated to static class members PubSub changes: - Refactored pubsub into class - Renamed files to `PubSub` instead of `Pubsub` - `PubSubSubscription` is now a private inner struct and `PubSub` only exposes `SubscriptionHandle` Lockable, ScopedLockable, Mutex: - Added `lock()` method that locks indefinitely - Remove deprecated `acquire()` and `release()` methods - Removed `TtWaitForever` in favour of `portMAX_DELAY`
74 lines
2.0 KiB
C++
74 lines
2.0 KiB
C++
#include <kernel/Kernel.h>
|
|
#include "Dispatcher.h"
|
|
#include "Check.h"
|
|
|
|
namespace tt {
|
|
|
|
#define TAG "dispatcher"
|
|
#define BACKPRESSURE_WARNING_COUNT ((EventBits_t)100)
|
|
#define WAIT_FLAG ((EventBits_t)1)
|
|
|
|
Dispatcher::~Dispatcher() {
|
|
// Wait for Mutex usage
|
|
mutex.lock();
|
|
mutex.unlock();
|
|
}
|
|
|
|
void Dispatcher::dispatch(Function function, std::shared_ptr<void> context) {
|
|
auto message = std::make_shared<DispatcherMessage>(function, std::move(context));
|
|
// Mutate
|
|
if (mutex.lock(1000 / portTICK_PERIOD_MS)) {
|
|
queue.push(std::move(message));
|
|
if (queue.size() == BACKPRESSURE_WARNING_COUNT) {
|
|
TT_LOG_W(TAG, "Backpressure: You're not consuming fast enough (100 queued)");
|
|
}
|
|
tt_check(mutex.unlock());
|
|
// Signal
|
|
eventFlag.set(WAIT_FLAG);
|
|
} else {
|
|
TT_LOG_E(TAG, LOG_MESSAGE_MUTEX_LOCK_FAILED);
|
|
}
|
|
}
|
|
|
|
uint32_t Dispatcher::consume(TickType_t timeout) {
|
|
// Wait for signal and clear
|
|
TickType_t start_ticks = kernel::getTicks();
|
|
if (eventFlag.wait(WAIT_FLAG, EventFlag::WaitAny, timeout)) {
|
|
eventFlag.clear(WAIT_FLAG);
|
|
} else {
|
|
return 0;
|
|
}
|
|
|
|
TickType_t ticks_remaining = TT_MAX(timeout - (kernel::getTicks() - start_ticks), 0);
|
|
|
|
TT_LOG_I(TAG, "Dispatcher continuing (%d ticks)", (int)ticks_remaining);
|
|
|
|
// Mutate
|
|
bool processing = true;
|
|
uint32_t consumed = 0;
|
|
do {
|
|
if (mutex.lock(ticks_remaining / portTICK_PERIOD_MS)) {
|
|
if (!queue.empty()) {
|
|
auto item = queue.front();
|
|
queue.pop();
|
|
consumed++;
|
|
processing = !queue.empty();
|
|
// Don't keep lock as callback might be slow
|
|
tt_check(mutex.unlock());
|
|
item->function(item->context);
|
|
} else {
|
|
processing = false;
|
|
tt_check(mutex.unlock());
|
|
}
|
|
|
|
} else {
|
|
TT_LOG_E(TAG, LOG_MESSAGE_MUTEX_LOCK_FAILED);
|
|
}
|
|
|
|
} while (processing);
|
|
|
|
return consumed;
|
|
}
|
|
|
|
} // namespace
|