Fixes and improvements

Documentation/ideas.md

@@ -2,17 +2,15 @@
 
 ## Higher Priority
 
-- Call tt::lvgl::isSyncSet after HAL init and show an error (and crash?) when it is not set.
 - External app loading: Check the version of Tactility and check ESP target hardware to check for compatibility.
 - App packaging
 - Make a URL handler. Use it for handling local files. Match file types with apps.
 - Fix Development service: when no SD card is present, the app fails to install. Consider installing to `/data`
-- Refactor `PropertiesFile.cpp` to use `tt::file::readLines()` (see TODO in code)
-- Localize all apps
-- Fix: Statusbar time updates result in errors when `system.properties` is not present.
+  Note: Change app install to "transfer file" functionality. We can have a proper install when we have app packaging.
 
 ## Lower Priority
 
+- Localize all apps
 - Support hot-plugging SD card (note: this is not possible if they require the CS pin hack)
 - Create more unit tests for `tactility`
 - Explore LVGL9's FreeRTOS functionality

Tactility/Source/app/development/Development.cpp

@@ -1,5 +1,7 @@
 #ifdef ESP_PLATFORM
 
+#include "Tactility/TactilityHeadless.h"
+
 #include <Tactility/app/AppManifest.h>
 #include <Tactility/lvgl/LvglSync.h>
 #include <Tactility/lvgl/Style.h>
@@ -51,7 +53,10 @@ class DevelopmentApp final : public App {
             bool is_on = lv_obj_has_state(widget, LV_STATE_CHECKED);
             bool is_changed = is_on != service::development::shouldEnableOnBoot();
             if (is_changed) {
-                service::development::setEnableOnBoot(is_on);
+                // Dispatch it, so file IO doesn't block the UI
+                getMainDispatcher().dispatch([is_on] {
+                    service::development::setEnableOnBoot(is_on);
+                });
             }
         }
     }

Tactility/Source/app/display/Display.cpp

@@ -1,3 +1,5 @@
+#include "Tactility/TactilityHeadless.h"
+
 #include <Tactility/settings/DisplaySettings.h>
 #include <Tactility/Assets.h>
 #include <Tactility/hal/display/DisplayDevice.h>
@@ -139,7 +141,11 @@ public:
 
     void onHide(TT_UNUSED AppContext& app) override {
         if (displaySettingsUpdated) {
-            settings::display::save(displaySettings);
+            // Dispatch it, so file IO doesn't block the UI
+            const settings::display::DisplaySettings settings_to_save = displaySettings;
+            getMainDispatcher().dispatch([settings_to_save] {
+                settings::display::save(settings_to_save);
+            });
         }
     }
 };

Tactility/Source/app/wifimanage/View.cpp

@@ -1,4 +1,6 @@
 #include "Tactility/app/wifimanage/View.h"
+
+#include "Tactility/TactilityHeadless.h"
 #include "Tactility/app/wifimanage/WifiManagePrivate.h"
 
 #include "Tactility/lvgl/Style.h"
@@ -49,7 +51,10 @@ static void on_enable_on_boot_switch_changed(lv_event_t* event) {
     auto* enable_switch = static_cast<lv_obj_t*>(lv_event_get_target(event));
     if (code == LV_EVENT_VALUE_CHANGED) {
         bool is_on = lv_obj_has_state(enable_switch, LV_STATE_CHECKED);
-        service::wifi::settings::setEnableOnBoot(is_on);
+        // Dispatch it, so file IO doesn't block the UI
+        getMainDispatcher().dispatch([is_on] {
+            service::wifi::settings::setEnableOnBoot(is_on);
+        });
     }
 }
 

Tactility/Source/file/PropertiesFile.cpp

@@ -21,31 +21,21 @@ bool getKeyValuePair(const std::string& input, std::string& key, std::string& va
 bool loadPropertiesFile(const std::string& filePath, std::function<void(const std::string& key, const std::string& value)> callback) {
     return file::withLock<bool>(filePath, [&filePath, &callback] {
         TT_LOG_I(TAG, "Reading properties file %s", filePath.c_str());
-        const auto input = readString(filePath);
-        if (input == nullptr) {
-            TT_LOG_E(TAG, "Failed to read file contents of %s", filePath.c_str());
-            return false;
-        }
-
-        const auto* input_start = reinterpret_cast<const char*>(input.get());
-        const std::string input_string = input_start;
-
         uint16_t line_count = 0;
-        // TODO: Rewrite to use file::readLines()
-        string::split(input_string, "\n", [&line_count, &filePath, &callback](auto token) {
+        return readLines(filePath, true, [&line_count, &filePath, &callback](const std::string& line) {
             line_count++;
             std::string key, value;
-            auto trimmed_token = string::trim(token, " \t");
-            if (!trimmed_token.starts_with("#")) {
-                if (getKeyValuePair(token, key, value)) {
+            auto trimmed_line = string::trim(line, " \t");
+            if (!trimmed_line.starts_with("#")) {
+                if (getKeyValuePair(trimmed_line, key, value)) {
                     std::string trimmed_key = string::trim(key, " \t");
                     std::string trimmed_value = string::trim(value, " \t");
                     callback(trimmed_key, trimmed_value);
-                } else { TT_LOG_E(TAG, "Failed to parse line %d of %s", line_count, filePath.c_str()); }
+                } else {
+                    TT_LOG_E(TAG, "Failed to parse line %d of %s", line_count, filePath.c_str());
+                }
             }
         });
-
-        return true;
     });
 }
 

Tactility/Source/settings/SystemSettings.cpp

@@ -7,11 +7,11 @@
 namespace tt::settings {
 
 constexpr auto* TAG = "SystemSettings";
-constexpr auto* FILE_PATH = "/data/system.properties";
+constexpr auto* FILE_PATH = "/data/settings/system.properties";
 
 static Mutex mutex = Mutex();
 static bool cached = false;
-static SystemSettings cachedProperties;
+static SystemSettings cachedSettings;
 
 static bool loadSystemSettingsFromFile(SystemSettings& properties) {
     std::map<std::string, std::string> map;
@@ -44,13 +44,13 @@ bool loadSystemSettings(SystemSettings& properties) {
     scoped_lock.lock();
 
     if (!cached) {
-        if (!loadSystemSettingsFromFile(cachedProperties)) {
+        if (!loadSystemSettingsFromFile(cachedSettings)) {
             return false;
         }
         cached = true;
     }
 
-    properties = cachedProperties;
+    properties = cachedSettings;
     return true;
 }
 
@@ -68,7 +68,7 @@ bool saveSystemSettings(const SystemSettings& properties) {
             return false;
         }
 
-        cachedProperties = properties;
+        cachedSettings = properties;
         cached = true;
         return true;
     });

sdkconfig.board.cyd-2432s024c

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.cyd-2432s028r

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.cyd-2432s032c

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.cyd-4848s040c

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.cyd-8048s043c

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.cyd-jc2432w328c

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.cyd-jc8048w550c

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.elecrow-crowpanel-advance-28

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.elecrow-crowpanel-advance-35

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.elecrow-crowpanel-advance-50

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.elecrow-crowpanel-basic-28

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.elecrow-crowpanel-basic-35

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.elecrow-crowpanel-basic-50

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.lilygo-tdeck

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.lilygo-tlora-pager

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.m5stack-core2

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.m5stack-cores3

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.unphone

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"

sdkconfig.board.waveshare-s3-touch-43

@@ -19,7 +19,7 @@ CONFIG_FREERTOS_HZ=1000
 CONFIG_FREERTOS_TASK_NOTIFICATION_ARRAY_ENTRIES=2
 CONFIG_FREERTOS_SMP=n
 CONFIG_FREERTOS_UNICORE=n
-CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
+CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=5120
 CONFIG_FREERTOS_USE_TRACE_FACILITY=y
 CONFIG_PARTITION_TABLE_CUSTOM=y
 CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"