PR feedback

This commit is contained in:
Ken Van Hoeylandt 2026-02-02 21:44:59 +01:00
parent 533abd5111
commit e2a4acb29b
4 changed files with 6 additions and 12 deletions

View File

@ -81,6 +81,7 @@ error_t module_destruct(struct Module* module);
/** /**
* @brief Add a module to the system. * @brief Add a module to the system.
* @warning Only call this once. This function does not check if it was added before.
* @param module module to add * @param module module to add
* @return ERROR_NONE if successful * @return ERROR_NONE if successful
*/ */
@ -127,7 +128,6 @@ bool module_resolve_symbol(struct Module* module, const char* symbol_name, uintp
/** /**
* @brief Resolve a symbol from any module * @brief Resolve a symbol from any module
* @details This function iterates through all started modules in the parent and attempts to resolve the symbol. * @details This function iterates through all started modules in the parent and attempts to resolve the symbol.
* @param parent parent module
* @param symbol_name name of the symbol to resolve * @param symbol_name name of the symbol to resolve
* @param symbol_address pointer to store the address of the resolved symbol * @param symbol_address pointer to store the address of the resolved symbol
* @return true if the symbol was found, false otherwise * @return true if the symbol was found, false otherwise

View File

@ -66,7 +66,7 @@ error_t kernel_init(struct Module* platform_module, struct Module* device_module
LOG_I(TAG, "init done"); LOG_I(TAG, "init done");
return ERROR_NONE; return ERROR_NONE;
}; }
#ifdef __cplusplus #ifdef __cplusplus
} }

View File

@ -66,9 +66,9 @@ extern "C" {
void log_generic(enum LogLevel level, const char* tag, const char* format, ...) { void log_generic(enum LogLevel level, const char* tag, const char* format, ...) {
va_list args; va_list args;
va_start(args, format); va_start(args, format);
printf("%s %c (%" PRIu64 ") \033[37m%s\033[0m ", get_log_color(level), get_log_prefix(level), get_log_timestamp(), tag); printf("%s %c (%" PRIu64 ") %s ", get_log_color(level), get_log_prefix(level), get_log_timestamp(), tag);
vprintf(format, args); vprintf(format, args);
printf("\n"); printf("\033[0m\n");
va_end(args); va_end(args);
} }

View File

@ -7,21 +7,15 @@
#include <tactility/kernel_init.h> #include <tactility/kernel_init.h>
#include <tactility/hal_device_module.h> #include <tactility/hal_device_module.h>
typedef struct { typedef struct {
int argc; int argc;
char** argv; char** argv;
int result; int result;
} TestTaskData; } TestTaskData;
extern "C" {
// From the relevant platform // From the relevant platform
extern struct Module platform_module; extern "C" struct Module platform_module;
}
struct ModuleParent tactility_tests_module_parent {
"tactility-tests",
nullptr
};
void test_task(void* parameter) { void test_task(void* parameter) {
auto* data = (TestTaskData*)parameter; auto* data = (TestTaskData*)parameter;