From 9ae3e486008b0285063ceb83d60f9928b02be362 Mon Sep 17 00:00:00 2001
From: Ken Van Hoeylandt <git@kenvanhoeylandt.net>
Date: Thu, 30 Oct 2025 22:46:52 +0100
Subject: [PATCH] Create bundle-firmware action for release branch (#401)

---
 .github/actions/bundle-firmware/action.yml | 15 +++++++++++++++
 .github/workflows/build-firmware.yml       | 10 +++++++++-
 .github/workflows/build-sdk.yml            |  4 ++--
 .github/workflows/tests.yml                |  2 +-
 Documentation/ideas.md                     |  3 +++
 5 files changed, 30 insertions(+), 4 deletions(-)
 create mode 100644 .github/actions/bundle-firmware/action.yml

diff --git a/.github/actions/bundle-firmware/action.yml b/.github/actions/bundle-firmware/action.yml
new file mode 100644
index 00000000..d723e30a
--- /dev/null
+++ b/.github/actions/bundle-firmware/action.yml
@@ -0,0 +1,15 @@
+name: Bundle All
+
+runs:
+  using: 'composite'
+  steps:
+    - name: 'Download artifacts'
+      uses: actions/download-artifact@v4
+      with:
+        path: firmwares
+    - name: 'Upload Artifact'
+      uses: actions/upload-artifact@v4
+      with:
+        name: 'all-firmwares'
+        path: firmwares/
+        retention-days: 3
diff --git a/.github/workflows/build-firmware.yml b/.github/workflows/build-firmware.yml
index fe807c30..80582123 100644
--- a/.github/workflows/build-firmware.yml
+++ b/.github/workflows/build-firmware.yml
@@ -9,7 +9,7 @@ on:
 permissions: read-all
 
 jobs:
-  build:
+  Build:
     strategy:
       matrix:
         board: [
@@ -54,3 +54,11 @@ jobs:
         with:
           board_id: ${{ matrix.board.id }}
           arch: ${{ matrix.board.arch }}
+  Bundle:
+    runs-on: ubuntu-latest
+    needs: [ Build ]
+    if: (github.event_name == 'pull_request' && startsWith(github.head_ref, 'release'))
+    steps:
+      - uses: actions/checkout@v4
+      - name: "Bundle"
+        uses: ./.github/actions/bundle-firmware
diff --git a/.github/workflows/build-sdk.yml b/.github/workflows/build-sdk.yml
index 3e61710a..9e8a4ba2 100644
--- a/.github/workflows/build-sdk.yml
+++ b/.github/workflows/build-sdk.yml
@@ -9,7 +9,7 @@ on:
 permissions: read-all
 
 jobs:
-  build:
+  Build:
     strategy:
       matrix:
         board: [
@@ -23,4 +23,4 @@ jobs:
         uses: ./.github/actions/build-sdk
         with:
           board_id: ${{ matrix.board.id }}
-          arch: ${{ matrix.board.arch }}
+          arch: ${{ matrix.board.arch }}
\ No newline at end of file
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index d48d446e..562729f0 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -4,7 +4,7 @@ on:
     branches:
       - main
   pull_request:
-    types: [opened, synchronize, reopened]
+    types: [ opened, synchronize, reopened ]
 jobs:
   run:
     runs-on: ubuntu-latest
diff --git a/Documentation/ideas.md b/Documentation/ideas.md
index 9d4c9153..de6f1672 100644
--- a/Documentation/ideas.md
+++ b/Documentation/ideas.md
@@ -2,6 +2,7 @@
 
 ## Before release
 
+- Issue with `enum DeviceType` when compiling from C (check all TactilityC enums!)
 - Automate release process more
 - Elecrow Basic & Advance 3.5" memory issue: not enough memory for App Hub
 - App Hub crashes if you close it while an app is being installed
@@ -9,6 +10,8 @@
 
 ## Higher Priority
 
+- Wi-Fi should connect to the access point with the strongest signal over similarly named APs
+- Wi-Fi connect app should focus on password field when SSID was passed on
 - Fix Cardputer (original): use LV_KEY_NEXT and _PREV in keyboard mapping instead of encoder driver hack (and check GPIO app if it then hangs too)
 - Logging with a function that uses std::format
 - Calculator bugs (see GitHub issue)