dominic/Tactility
1
0
Fork 0
mirror of https://github.com/ByteWelder/Tactility.git synced 2026-10-17 10:55:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for content length

Browse Source
This commit is contained in:
Ken Van Hoeylandt 2026-10-16 08:50:43 +02:00
parent 6baf92581b
commit 8a54e906dc
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Modules/http-module/source/download_posix.cpp
View File

@ -301,6 +301,7 @@ HttpDownloadEvent http_download_run(const std::string& url, const std::string& c
long contentLength = -1; long contentLength = -1;
std::string contentLengthValue; std::string contentLengthValue;
bool hasContentLength = false; bool hasContentLength = false;
bool hasConflictingContentLengths = false;
bool chunked = false; bool chunked = false;
while (true) { while (true) {
if (!connection.readLine(line)) { if (!connection.readLine(line)) {
@ -315,6 +316,10 @@ HttpDownloadEvent http_download_run(const std::string& url, const std::string& c
continue; continue;
} }
if (name == "content-length") { if (name == "content-length") {
// Repeated headers must have the same value, or the body's end is ambiguous
if (hasContentLength && value != contentLengthValue) {
hasConflictingContentLengths = true;
}
contentLengthValue = value; contentLengthValue = value;
hasContentLength = true; hasContentLength = true;
} else if (name == "transfer-encoding" && value.find("chunked") != std::string::npos) { } else if (name == "transfer-encoding" && value.find("chunked") != std::string::npos) {
@ -326,7 +331,7 @@ HttpDownloadEvent http_download_run(const std::string& url, const std::string& c
return http_download_make_error_event("Server response is not OK", statusCode); return http_download_make_error_event("Server response is not OK", statusCode);
} }
// A chunked body ignores the Content-Length // A chunked body ignores the Content-Length
if (hasContentLength && !chunked && !http_parse_content_length(contentLengthValue, contentLength)) { if (hasContentLength && !chunked && (hasConflictingContentLengths || !http_parse_content_length(contentLengthValue, contentLength))) {
return http_download_make_error_event("Invalid Content-Length", statusCode); return http_download_make_error_event("Invalid Content-Length", statusCode);
} }
if (http_download_is_cancelled(link)) { if (http_download_is_cancelled(link)) {