dominic/Tactility
1
0
Fork 0
mirror of https://github.com/ByteWelder/Tactility.git synced 2026-08-19 16:35:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refcount check is not meant for device_stop() but for device_destruct()

Browse Source
This commit is contained in:
Ken Van Hoeylandt 2026-07-27 00:39:58 +02:00
parent 1271e479b8
commit 7e97de36cd
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
TactilityKernel/source/device.cpp
View File

@ -94,6 +94,10 @@ error_t device_destruct(Device* device) {
auto* internal = device->internal; auto* internal = device->internal;
if (internal->ref_count > 0) {
unlock_internal(device->internal);
return ERROR_RESOURCE_BUSY;
}
if (internal->state.started || internal->state.added) { if (internal->state.started || internal->state.added) {
unlock_internal(device->internal); unlock_internal(device->internal);
return ERROR_INVALID_STATE; return ERROR_INVALID_STATE;
@ -102,13 +106,6 @@ error_t device_destruct(Device* device) {
unlock_internal(device->internal); unlock_internal(device->internal);
return ERROR_INVALID_STATE; return ERROR_INVALID_STATE;
} }
// Callers are expected to sequence teardown correctly (device_stop() already refuses to
// clear `started` while ref_count > 0, so by the time !started holds above, ref_count is
// already 0) - this is a cheap defense-in-depth check, not a substitute for that discipline.
if (internal->ref_count > 0) {
unlock_internal(device->internal);
return ERROR_RESOURCE_BUSY;
}
LOG_D(TAG, "destruct %s", device->name); LOG_D(TAG, "destruct %s", device->name);
device->internal = nullptr; device->internal = nullptr;
@ -253,11 +250,6 @@ error_t device_stop(Device* device) {
return ERROR_NONE; return ERROR_NONE;
} }
if (internal->ref_count > 0) {
unlock_internal(internal);
return ERROR_RESOURCE_BUSY;
}
// Already stopping on another thread // Already stopping on another thread
if (internal->state.stopping) { if (internal->state.stopping) {
unlock_internal(internal); unlock_internal(internal);
@ -266,10 +258,6 @@ error_t device_stop(Device* device) {
internal->state.stopping = true; internal->state.stopping = true;
unlock_internal(internal); unlock_internal(internal);
// driver_unbind() runs the driver's stop_device callback, which may remove/destruct child
// devices (device_remove() takes ledger_lock) - `mutex` must stay released across this call,
// same reasoning as device_start(). state.stopping keeps device_get() from handing out a new
// ref while ref_count is meant to stay at 0 during the unbind.
error_t unbind_error = driver_unbind(internal->driver, device); error_t unbind_error = driver_unbind(internal->driver, device);
lock_internal(internal); lock_internal(internal);