Fixes

Devices/m5stack-papers3/source/module.cpp

@@ -7,7 +7,7 @@ extern Driver papers3_power_driver;
 extern Driver papers3_power_supply_driver;
 extern Driver papers3_display_driver;
 
-static const Driver* papers3_drivers[] = {
+static Driver* const papers3_drivers[] = {
     &papers3_display_driver,
     &papers3_power_driver,
     &papers3_power_supply_driver,

Devices/m5stack-tab5/Source/module.cpp

@@ -79,7 +79,7 @@ static error_t stop() {
     return ERROR_NONE;
 }
 
-static const Driver* tab5_drivers[] = {
+static Driver* const tab5_drivers[] = {
     &tab5_keyboard_driver,
     &tab5_power_control_driver,
     nullptr
@@ -89,7 +89,7 @@ Module m5stack_tab5_module = {
     .name = "m5stack-tab5",
     .start = start,
     .stop = stop,
-    .drivers = const_cast<const Driver**>(tab5_drivers)
+    .drivers = tab5_drivers
 };
 
 }

Devices/unphone/source/module.cpp

@@ -47,7 +47,7 @@ static error_t stop() {
     return ERROR_NONE;
 }
 
-static const Driver* unphone_drivers[] = {
+static Driver* const unphone_drivers[] = {
     &unphone_nav_buttons_driver,
     &unphone_power_switch_driver,
     nullptr

Drivers/aw88298-module/source/module.cpp

@@ -8,7 +8,7 @@ extern Driver aw88298_driver;
 
 extern const ModuleSymbol aw88298_module_symbols[];
 
-static const Driver* aw88298_drivers[] = {
+static Driver* const aw88298_drivers[] = {
     &aw88298_driver,
     nullptr
 };

Drivers/aw9523b-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver aw9523b_driver;
 
-static const Driver* aw9523b_drivers[] = {
+static Driver* const aw9523b_drivers[] = {
     &aw9523b_driver,
     nullptr
 };

Drivers/axp192-module/source/module.cpp

@@ -9,7 +9,7 @@ extern Driver axp192_driver;
 extern Driver axp192_power_supply_driver;
 extern Driver axp192_backlight_driver;
 
-static const Driver* axp192_drivers[] = {
+static Driver* const axp192_drivers[] = {
     &axp192_driver,
     &axp192_power_supply_driver,
     &axp192_backlight_driver,

Drivers/axp2101-module/source/module.cpp

@@ -9,7 +9,7 @@ extern Driver axp2101_driver;
 extern Driver axp2101_power_supply_driver;
 extern Driver axp2101_backlight_driver;
 
-static const Driver* axp2101_drivers[] = {
+static Driver* const axp2101_drivers[] = {
     &axp2101_driver,
     &axp2101_power_supply_driver,
     &axp2101_backlight_driver,

Drivers/axs5106-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver axs5106_driver;
 
-static const Driver* axs5106_drivers[] = {
+static Driver* const axs5106_drivers[] = {
     &axs5106_driver,
     nullptr
 };

Drivers/bm8563-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver bm8563_driver;
 
-static const Driver* bm8563_drivers[] = {
+static Driver* const bm8563_drivers[] = {
     &bm8563_driver,
     nullptr
 };

Drivers/bmi270-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver bmi270_driver;
 
-static const Driver* bmi270_drivers[] = {
+static Driver* const bmi270_drivers[] = {
     &bmi270_driver,
     nullptr
 };

Drivers/bq24295-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver bq24295_driver;
 extern Driver bq24295_power_supply_driver;
 
-static const Driver* bq24295_drivers[] = {
+static Driver* const bq24295_drivers[] = {
     &bq24295_driver,
     &bq24295_power_supply_driver,
     nullptr

Drivers/bq25896-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver bq25896_driver;
 extern Driver bq25896_power_supply_driver;
 
-static const Driver* bq25896_drivers[] = {
+static Driver* const bq25896_drivers[] = {
     &bq25896_driver,
     &bq25896_power_supply_driver,
     nullptr

Drivers/bq27220-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver bq27220_driver;
 extern Driver bq27220_power_supply_driver;
 
-static const Driver* bq27220_drivers[] = {
+static Driver* const bq27220_drivers[] = {
     &bq27220_driver,
     &bq27220_power_supply_driver,
     nullptr

Drivers/button-control-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver button_control_driver;
 
-static const Driver* button_control_drivers[] = {
+static Driver* const button_control_drivers[] = {
     &button_control_driver,
     nullptr
 };

Drivers/ch422g-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ch422g_driver;
 
-static const Driver* ch422g_drivers[] = {
+static Driver* const ch422g_drivers[] = {
     &ch422g_driver,
     nullptr
 };

Drivers/cst328-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver cst328_driver;
 
-static const Driver* cst328_drivers[] = {
+static Driver* const cst328_drivers[] = {
     &cst328_driver,
     nullptr
 };

Drivers/cst66xx-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver cst66xx_driver;
 
-static const Driver* cst66xx_drivers[] = {
+static Driver* const cst66xx_drivers[] = {
     &cst66xx_driver,
     nullptr
 };

Drivers/cst816s-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver cst816s_driver;
 
-static const Driver* cst816s_drivers[] = {
+static Driver* const cst816s_drivers[] = {
     &cst816s_driver,
     nullptr
 };

Drivers/cst816t-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver cst816t_driver;
 
-static const Driver* cst816t_drivers[] = {
+static Driver* const cst816t_drivers[] = {
     &cst816t_driver,
     nullptr
 };

Drivers/drv2605-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver drv2605_driver;
 
-static const Driver* drv2605_drivers[] = {
+static Driver* const drv2605_drivers[] = {
     &drv2605_driver,
     nullptr
 };

Drivers/dummy-i2s-amp-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver dummy_i2s_amp_driver;
 
-static const Driver* dummy_drivers[] = {
+static Driver* const dummy_drivers[] = {
     &dummy_i2s_amp_driver,
     nullptr
 };

Drivers/es7210-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver es7210_driver;
 
-static const Driver* es7210_drivers[] = {
+static Driver* const es7210_drivers[] = {
     &es7210_driver,
     nullptr
 };

Drivers/es8311-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver es8311_driver;
 
-static const Driver* es8311_drivers[] = {
+static Driver* const es8311_drivers[] = {
     &es8311_driver,
     nullptr
 };

Drivers/es8388-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver es8388_driver;
 
-static const Driver* es8388_drivers[] = {
+static Driver* const es8388_drivers[] = {
     &es8388_driver,
     nullptr
 };

Drivers/ft5x06-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ft5x06_driver;
 
-static const Driver* ft5x06_drivers[] = {
+static Driver* const ft5x06_drivers[] = {
     &ft5x06_driver,
     nullptr
 };

Drivers/ft6x36-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ft6x36_driver;
 
-static const Driver* ft6x36_drivers[] = {
+static Driver* const ft6x36_drivers[] = {
     &ft6x36_driver,
     nullptr
 };

Drivers/gc9a01-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver gc9a01_driver;
 
-static const Driver* gc9a01_drivers[] = {
+static Driver* const gc9a01_drivers[] = {
     &gc9a01_driver,
     nullptr
 };

Drivers/gt911-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver gt911_driver;
 
-static const Driver* gt911_drivers[] = {
+static Driver* const gt911_drivers[] = {
     &gt911_driver,
     nullptr
 };

Drivers/hx8357-module/source/module.cpp

@@ -4,7 +4,7 @@
 
 extern Driver hx8357_driver;
 
-static const Driver* hx8357_drivers[] = {
+static Driver* const hx8357_drivers[] = {
     &hx8357_driver,
     nullptr
 };

Drivers/ili9341-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ili9341_driver;
 
-static const Driver* ili9341_drivers[] = {
+static Driver* const ili9341_drivers[] = {
     &ili9341_driver,
     nullptr
 };

Drivers/ili9488-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ili9488_driver;
 
-static const Driver* ili9488_drivers[] = {
+static Driver* const ili9488_drivers[] = {
     &ili9488_driver,
     nullptr
 };

Drivers/ili9881c-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ili9881c_driver;
 
-static const Driver* ili9881c_drivers[] = {
+static Driver* const ili9881c_drivers[] = {
     &ili9881c_driver,
     nullptr
 };

Drivers/ina226-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver ina226_driver;
 extern Driver ina226_power_supply_driver;
 
-static const Driver* ina226_drivers[] = {
+static Driver* const ina226_drivers[] = {
     &ina226_driver,
     &ina226_power_supply_driver,
     nullptr

Drivers/jd9165-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver jd9165_driver;
 
-static const Driver* jd9165_drivers[] = {
+static Driver* const jd9165_drivers[] = {
     &jd9165_driver,
     nullptr
 };

Drivers/jd9853-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver jd9853_driver;
 
-static const Driver* jd9853_drivers[] = {
+static Driver* const jd9853_drivers[] = {
     &jd9853_driver,
     nullptr
 };

Drivers/lilygo-module/source/module.cpp

@@ -9,7 +9,7 @@ extern Driver tdeck_keyboard_backlight_driver;
 extern Driver tdeck_trackball_driver;
 extern Driver tpager_encoder_driver;
 
-static const Driver* lilygo_drivers[] = {
+static Driver* const lilygo_drivers[] = {
     &tdeck_keyboard_driver,
     &tdeck_keyboard_backlight_driver,
     &tdeck_trackball_driver,

Drivers/m5pm1-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver m5pm1_driver;
 extern Driver m5pm1_power_supply_driver;
 
-static const Driver* m5pm1_drivers[] = {
+static Driver* const m5pm1_drivers[] = {
     &m5pm1_driver,
     &m5pm1_power_supply_driver,
     nullptr

Drivers/m5stack-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver cardputer_keyboard_driver;
 extern Driver cardputer_adv_keyboard_driver;
 
-static const Driver* m5stack_drivers[] = {
+static Driver* const m5stack_drivers[] = {
     &cardputer_keyboard_driver,
     &cardputer_adv_keyboard_driver,
     nullptr

Drivers/mpu6886-module/source/module.cpp

@@ -6,25 +6,11 @@ extern "C" {
 
 extern Driver mpu6886_driver;
 
-static const Driver* mpu6886_drivers[] = {
+static Driver* const mpu6886_drivers[] = {
     &mpu6886_driver,
     nullptr
 };
 
-static error_t start() {
-    /* We crash when construct fails, because if a single driver fails to construct,
-     * there is no guarantee that the previously constructed drivers can be destroyed */
-    check(driver_construct_add(&mpu6886_driver) == ERROR_NONE);
-    return ERROR_NONE;
-}
-
-static error_t stop() {
-    /* We crash when destruct fails, because if a single driver fails to destruct,
-     * there is no guarantee that the previously destroyed drivers can be recovered */
-    check(driver_remove_destruct(&mpu6886_driver) == ERROR_NONE);
-    return ERROR_NONE;
-}
-
 extern const ModuleSymbol mpu6886_module_symbols[];
 
 Module mpu6886_module = {

Drivers/pdm-mic-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver pdm_mic_driver;
 
-static const Driver* pdm_mic_drivers[] = {
+static Driver* const pdm_mic_drivers[] = {
     &pdm_mic_driver,
     nullptr
 };

Drivers/pi4ioe5v6408-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver pi4ioe5v6408_driver;
 
-static const Driver* pi4ioe5v6408_drivers[] = {
+static Driver* const pi4ioe5v6408_drivers[] = {
     &pi4ioe5v6408_driver,
     nullptr
 };

Drivers/py32ioexpander-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver py32ioexpander_driver;
 
-static const Driver* py32ioexpander_drivers[] = {
+static Driver* const py32ioexpander_drivers[] = {
     &py32ioexpander_driver,
     nullptr
 };

Drivers/qmi8658-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver qmi8658_driver;
 
-static const Driver* qmi8658_drivers[] = {
+static Driver* const qmi8658_drivers[] = {
     &qmi8658_driver,
     nullptr
 };

Drivers/rgb-display-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver rgb_display_driver;
 
-static const Driver* rgbd_display_drivers[] = {
+static Driver* const rgbd_display_drivers[] = {
     &rgb_display_driver,
     nullptr
 };

Drivers/rx8130ce-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver rx8130ce_driver;
 
-static const Driver* rx8130ce_drivers[] = {
+static Driver* const rx8130ce_drivers[] = {
     &rx8130ce_driver,
     nullptr
 };

Drivers/sc2356-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver sc2356_driver;
 
-static const Driver* sc2356_drivers[] = {
+static Driver* const sc2356_drivers[] = {
     &sc2356_driver,
     nullptr
 };

Drivers/ssd1306-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver ssd1306_driver;
 
-static const Driver* ssd1306_drivers[] = {
+static Driver* const ssd1306_drivers[] = {
     &ssd1306_driver,
     nullptr
 };

Drivers/st7123-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver st7123_driver;
 extern Driver st7123_touch_driver;
 
-static const Driver* st7123_drivers[] = {
+static Driver* const st7123_drivers[] = {
     &st7123_driver,
     &st7123_touch_driver,
     nullptr

Drivers/st7701-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver st7701_driver;
 
-static const Driver* st7701_drivers[] = {
+static Driver* const st7701_drivers[] = {
     &st7701_driver,
     nullptr
 };

Drivers/st7735-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver st7735_driver;
 
-static const Driver* st7735_drivers[] = {
+static Driver* const st7735_drivers[] = {
     &st7735_driver,
     nullptr
 };

Drivers/st7789-i8080-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver st7789_i8080_driver;
 
-static const Driver* st7789_i8080_drivers[] = {
+static Driver* const st7789_i8080_drivers[] = {
     &st7789_i8080_driver,
     nullptr
 };

Drivers/st7789-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver st7789_driver;
 
-static const Driver* st7789_drivers[] = {
+static Driver* const st7789_drivers[] = {
     &st7789_driver,
     nullptr
 };

Drivers/st7796-i8080-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver st7796_i8080_driver;
 
-static const Driver* st7796_i8080_drivers[] = {
+static Driver* const st7796_i8080_drivers[] = {
     &st7796_i8080_driver,
     nullptr
 };

Drivers/st7796-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver st7796_driver;
 
-static const Driver* st7796_drivers[] = {
+static Driver* const st7796_drivers[] = {
     &st7796_driver,
     nullptr
 };

Drivers/sy6970-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver sy6970_driver;
 extern Driver sy6970_power_supply_driver;
 
-static const Driver* sy6970_drivers[] = {
+static Driver* const sy6970_drivers[] = {
     &sy6970_driver,
     &sy6970_power_supply_driver,
     nullptr

Drivers/tca8418-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver tca8418_driver;
 
-static const Driver* tca8418_drivers[] = {
+static Driver* const tca8418_drivers[] = {
     &tca8418_driver,
     nullptr
 };

Drivers/tca9534-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver tca9534_driver;
 
-static const Driver* tca9534_drivers[] = {
+static Driver* const tca9534_drivers[] = {
     &tca9534_driver,
     nullptr
 };

Drivers/tca95xx-16bit-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver tca95xx_driver;
 
-static const Driver* tca95xx_drivers[] = {
+static Driver* const tca95xx_drivers[] = {
     &tca95xx_driver,
     nullptr
 };

Drivers/xl9555-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver xl9555_driver;
 
-static const Driver* xl9555_drivers[] = {
+static Driver* const xl9555_drivers[] = {
     &xl9555_driver,
     nullptr
 };

Drivers/xpt2046-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver xpt2046_driver;
 extern Driver xpt2046_power_supply_driver;
 
-static const Driver* xpt2046_drivers[] = {
+static Driver* const xpt2046_drivers[] = {
     &xpt2046_driver,
     &xpt2046_power_supply_driver,
     nullptr

Drivers/xpt2046-softspi-module/source/module.cpp

@@ -7,7 +7,7 @@ extern "C" {
 extern Driver xpt2046_softspi_driver;
 extern Driver xpt2046_softspi_power_supply_driver;
 
-static const Driver* xpt2046_softspi_drivers[] = {
+static Driver* const xpt2046_softspi_drivers[] = {
     &xpt2046_softspi_driver,
     &xpt2046_softspi_power_supply_driver,
     nullptr

Modules/hal-device-module/source/module.cpp

@@ -6,7 +6,7 @@ extern "C" {
 
 extern Driver hal_device_driver;
 
-static const Driver* hal_device_drivers[] = {
+static Driver* const hal_device_drivers[] = {
     &hal_device_driver,
     nullptr
 };

TactilityKernel/include/tactility/module.h

@@ -57,7 +57,7 @@ struct Module {
      * When the module is started, these drivers are constructed and added to the module.
      * When the module is stopped, these drivers are removed from the module and destroyed.
      */
-    const struct Driver** drivers;
+    struct Driver* const* drivers;
     /**
      * A list of symbols exported by the module.
      * Should be terminated by MODULE_SYMBOL_TERMINATOR.

TactilityKernel/source/module.cpp

@@ -70,7 +70,7 @@ error_t module_start(Module* module) {
         auto* driver_location = module->drivers;
         while (*driver_location != nullptr) {
             auto driver = *driver_location;
-            driver_construct_add(driver);
+            check(driver_construct_add(driver) == ERROR_NONE);
             driver_location++;
         }
     }
@@ -92,11 +92,12 @@ error_t module_stop(Module* module) {
     if (!internal->started) return ERROR_NONE;
 
     if (module->drivers != nullptr) {
-        auto* driver_location = module->drivers;
+        size_t count = 0;
-        while (*driver_location != nullptr) {
+        while (module->drivers[count] != nullptr) {
-            auto driver = *driver_location;
+            count++;
-            driver_remove_destruct(driver);
+        }
-            driver_location++;
+        for (size_t i = count; i-- > 0;) {
+            check(driver_remove_destruct(module->drivers[i]) == ERROR_NONE);
         }
     }
 
@@ -105,7 +106,6 @@ error_t module_stop(Module* module) {
         if (error != ERROR_NONE) {
             return error;
         }
-
     }
 
     internal->started = false;