From 058cad7ca087d15fbac0e0e23640cea0f43caaf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominic=20H=C3=B6glinger?= Date: Fri, 26 Sep 2025 17:43:01 +0200 Subject: [PATCH] SX1262: Remove warnings on unavailable parameter fetch --- Drivers/SX126x/Source/Sx1262.cpp | 6 +++--- Drivers/SX126x/Source/Sx1262.h | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Drivers/SX126x/Source/Sx1262.cpp b/Drivers/SX126x/Source/Sx1262.cpp index 4a87b757..5295b051 100644 --- a/Drivers/SX126x/Source/Sx1262.cpp +++ b/Drivers/SX126x/Source/Sx1262.cpp @@ -94,6 +94,8 @@ Sx1262::ParameterStatus Sx1262::setLrFhssParameter(const Parameter parameter, co using enum Parameter; switch (parameter) { + case Power: + return checkLimitsAndApply(power, value, -9.0, 22.0); case Bandwidth: return checkValuesAndApply(bandwidth, value, { 39.06, 85.94, 136.72, 183.59, 335.94, 386.72, 722.66, 773.44, 1523.4, 1574.2 @@ -163,7 +165,6 @@ Sx1262::ParameterStatus Sx1262::getLoraParameter(const Parameter parameter, floa break; } - TT_LOG_W(TAG, "Tried to get unsupported LoRa parameter \"%s\"", toString(parameter)); return Sx1262::ParameterStatus::Unavailable; } @@ -190,7 +191,6 @@ Sx1262::ParameterStatus Sx1262::getFskParameter(const Parameter parameter, float break; } - TT_LOG_W(TAG, "Tried to get unsupported FSK parameter \"%s\"", toString(parameter)); return Sx1262::ParameterStatus::Unavailable; } @@ -214,7 +214,6 @@ Sx1262::ParameterStatus Sx1262::getLrFhssParameter(const Parameter parameter, fl break; } - TT_LOG_W(TAG, "Tried to get unsupported LR-FHSS parameter \"%s\"", toString(parameter)); return Sx1262::ParameterStatus::Unavailable; } @@ -222,6 +221,7 @@ Sx1262::ParameterStatus Sx1262::getLrFhssParameter(const Parameter parameter, fl Sx1262::ParameterStatus Sx1262::getParameter(const Parameter parameter, float &value) const { const auto currentModulation = getModulation(); + // No warnings are emitted to be able to discover parameters by return status switch (currentModulation) { case Modulation::LoRa: return getLoraParameter(parameter, value); diff --git a/Drivers/SX126x/Source/Sx1262.h b/Drivers/SX126x/Source/Sx1262.h index ad00d16c..40aaa22a 100644 --- a/Drivers/SX126x/Source/Sx1262.h +++ b/Drivers/SX126x/Source/Sx1262.h @@ -41,8 +41,9 @@ private: SX1262 radio; TxItem currentTx; - int8_t power = 0; - float frequency = 0.0; + // Shared parameters which have a common lowest value are set here + int8_t power = -9.0; + float frequency = 150; float bandwidth = 0.0; uint8_t spreadFactor = 0.0; uint8_t codingRate = 0;